Skip to content

Commit

Permalink
Reduce logging during minidump processing
Browse files Browse the repository at this point in the history
Change-Id: Ie62795137770cff7cda7494c5527457b1e355897
Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/5402921
Reviewed-by: Ivan Penkov <ivanpe@chromium.org>
  • Loading branch information
Joshua Peraza committed Mar 29, 2024
1 parent a86123f commit e5dc1f8
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 5 deletions.
2 changes: 0 additions & 2 deletions src/processor/minidump_processor.cc
Original file line number Diff line number Diff line change
Expand Up @@ -823,8 +823,6 @@ static void CalculateFaultAddressFromInstruction(Minidump* dump,

DisassemblerObjdump disassembler(context->GetContextCPU(), memory_region,
instruction_ptr);
fprintf(stderr, "%s %s %s\n", disassembler.operation().c_str(),
disassembler.src().c_str(), disassembler.dest().c_str());
if (!disassembler.IsValid()) {
BPLOG(INFO) << "Disassembling fault instruction failed.";
return;
Expand Down
1 change: 0 additions & 1 deletion src/processor/stackwalker_amd64.cc
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,6 @@ StackFrameAMD64* StackwalkerAMD64::GetCallerByCFIFrameInfo(
return NULL;

if (!frame->context.rip || !frame->context.rsp) {
BPLOG(ERROR) << "invalid rip/rsp";
return NULL;
}

Expand Down
2 changes: 0 additions & 2 deletions src/processor/stackwalker_arm64.cc
Original file line number Diff line number Diff line change
Expand Up @@ -289,8 +289,6 @@ void StackwalkerARM64::CorrectRegLRByFramePointer(
uint64_t last_fp = 0;
if (last_frame_callee_fp &&
!memory_->GetMemoryAtAddress(last_frame_callee_fp, &last_fp)) {
BPLOG(ERROR) << "Unable to read last_fp from last_last_fp: 0x" << std::hex
<< last_frame_callee_fp;
return;
}
// Give up if STACK CFI doesn't agree with frame pointer.
Expand Down

0 comments on commit e5dc1f8

Please sign in to comment.