Generate code that formats faster with "short" style. (#1336)

google · Dec 18, 2024 · 306b669 · 306b669
1 parent b0f0eb9
commit 306b669
Show file tree

Hide file tree

Showing 31 changed files with 661 additions and 488 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,8 @@
 
 # 8.9.3 (unreleased)
 
+- Generate code that formats faster with current "short" style. Both versions
+  are fast with the coming "tall" style.
 - Mark `@nullable` deprecated: it does nothing and should not be used.
 
 # 8.9.2

diff --git a/benchmark/lib/node.g.dart b/benchmark/lib/node.g.dart
diff --git a/benchmark/lib/simple_value.g.dart b/benchmark/lib/simple_value.g.dart
diff --git a/built_value_generator/lib/src/enum_source_class.g.dart b/built_value_generator/lib/src/enum_source_class.g.dart
diff --git a/built_value_generator/lib/src/enum_source_field.g.dart b/built_value_generator/lib/src/enum_source_field.g.dart
diff --git a/built_value_generator/lib/src/enum_source_library.g.dart b/built_value_generator/lib/src/enum_source_library.g.dart
diff --git a/built_value_generator/lib/src/fixes.g.dart b/built_value_generator/lib/src/fixes.g.dart
diff --git a/built_value_generator/lib/src/memoized_getter.g.dart b/built_value_generator/lib/src/memoized_getter.g.dart
diff --git a/built_value_generator/lib/src/serializer_source_class.g.dart b/built_value_generator/lib/src/serializer_source_class.g.dart
diff --git a/built_value_generator/lib/src/serializer_source_field.g.dart b/built_value_generator/lib/src/serializer_source_field.g.dart
diff --git a/built_value_generator/lib/src/serializer_source_library.g.dart b/built_value_generator/lib/src/serializer_source_library.g.dart
diff --git a/built_value_generator/lib/src/value_source_class.dart b/built_value_generator/lib/src/value_source_class.dart
@@ -1104,20 +1104,23 @@ abstract class ValueSourceClass
     }
     result.writeln('_\$result = _\$v ?? ');
     result.writeln('new $implName$_generics._(');
-    result.write(fieldBuilders.keys.map((field) {
-      final fieldBuilder = fieldBuilders[field];
-      if (needsNullCheck.contains(field)) {
-        if (genericFields.containsKey(field)) {
-          final genericType = genericFields[field];
-          return '$field: null is $genericType ? $fieldBuilder as $genericType '
-              ': BuiltValueNullFieldError.checkNotNull($fieldBuilder'
-              ", r'$name', '${escapeString(field)}')";
-        }
-        return '$field: BuiltValueNullFieldError.checkNotNull($fieldBuilder, '
-            "r'$name', '${escapeString(field)}')";
-      }
-      return '$field: $fieldBuilder';
-    }).join(','));
+    result.write(fieldBuilders.keys
+        .map((field) {
+          final fieldBuilder = fieldBuilders[field];
+          if (needsNullCheck.contains(field)) {
+            if (genericFields.containsKey(field)) {
+              final genericType = genericFields[field];
+              return '$field: null is $genericType ? $fieldBuilder as $genericType '
+                  ': BuiltValueNullFieldError.checkNotNull($fieldBuilder'
+                  ", r'$name', '${escapeString(field)}')";
+            }
+            return '$field: BuiltValueNullFieldError.checkNotNull($fieldBuilder, '
+                "r'$name', '${escapeString(field)}')";
+          }
+          return '$field: $fieldBuilder';
+        })
+        .map((fieldBuilder) => '$fieldBuilder,')
+        .join(''));
     result.writeln(');');
 
     if (needsTryCatchOnBuild) {

diff --git a/built_value_generator/lib/src/value_source_class.g.dart b/built_value_generator/lib/src/value_source_class.g.dart
diff --git a/built_value_generator/lib/src/value_source_field.g.dart b/built_value_generator/lib/src/value_source_field.g.dart
diff --git a/built_value_test/test/values.g.dart b/built_value_test/test/values.g.dart