feat: allow non alphanumeric characters in enum class names (#1297)

Signed-off-by: Nikolas Rimikis <leptopoda@users.noreply.github.com>
Co-authored-by: Nikolas Rimikis <leptopoda@users.noreply.github.com>

CHANGELOG.md

@@ -3,6 +3,7 @@
 # 8.9.0-wip
 
 - Add ignoring types that the StandardJsonPlugin should leave as a List.
+- Allow non alphanumeric characters in enum class names.
 
 # 8.8.1
 

built_value_generator/lib/src/enum_source_class.dart

@@ -81,8 +81,8 @@ abstract class EnumSourceClass
     if (getter == null) return null;
     var source = parsedLibrary.getElementDeclaration(getter)!.node.toSource();
     var matches = RegExp(r'static BuiltSet<' +
-            element.displayName +
-            r'> get values => (_\$\w+)\;')
+            RegExp.escape(element.displayName) +
+            r'> get values => (_\$[\w$]+)\;')
         .allMatches(source);
     return matches.isEmpty ? null : matches.first.group(1);
   }
@@ -93,8 +93,8 @@ abstract class EnumSourceClass
     if (getter == null) return null;
     var source = parsedLibrary.getElementDeclaration(getter)!.node.toSource();
     var matches = RegExp(r'static ' +
-            element.displayName +
-            r' valueOf\((?:final )?String name\) \=\> (\_\$\w+)\(name\)\;')
+            RegExp.escape(element.displayName) +
+            r' valueOf\((?:final )?String name\) \=\> (\_\$[\w$]+)\(name\)\;')
         .allMatches(source);
     return matches.isEmpty ? null : matches.first.group(1);
   }
@@ -153,9 +153,10 @@ abstract class EnumSourceClass
   }
 
   Iterable<String> _checkConstructor() {
-    var expectedCode =
-        RegExp('const $name._\\((?:final )?String name\\) : super\\(name\\);');
-    var expectedCode217 = RegExp('const $name._\\(super.name\\);');
+    var expectedCode = RegExp(
+        'const ${RegExp.escape(name)}._\\((?:final )?String name\\) : super\\(name\\);');
+    var expectedCode217 =
+        RegExp('const ${RegExp.escape(name)}._\\(super.name\\);');
     return constructors.length == 1 &&
             (constructors.single.contains(expectedCode) ||
                 constructors.single.contains(expectedCode217))

end_to_end_test/lib/enums.dart

@@ -119,3 +119,23 @@ class FallbackNumberEnum extends EnumClass {
   static BuiltSet<FallbackNumberEnum> get values => _$fbNumberValues;
   static FallbackNumberEnum valueOf(String name) => _$fbNumberValueOf(name);
 }
+
+class EnumWith$Dollar_UnderScore extends EnumClass {
+  static Serializer<EnumWith$Dollar_UnderScore> get serializer =>
+      _$enumWith$DollarUnderScoreSerializer;
+
+  @BuiltValueEnumConst(wireNumber: 0)
+  static const EnumWith$Dollar_UnderScore $value =
+      _$dollar_UnderScoreEnum$Value;
+
+  @BuiltValueEnumConst(wireNumber: -1, fallback: true)
+  static const EnumWith$Dollar_UnderScore value$ =
+      _$dollar_UnderScoreEnumValue$;
+
+  const EnumWith$Dollar_UnderScore._(String name) : super(name);
+
+  static BuiltSet<EnumWith$Dollar_UnderScore> get values =>
+      _$enum$Dollar_UnderScoreValues;
+  static EnumWith$Dollar_UnderScore valueOf(String name) =>
+      _$enum$Dollar_UnderScoreValueOf(name);
+}