Add random address generation methods #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
barbibulle
reviewed
Dec 22, 2023
bumble/hci.py
Outdated
| @@ -1881,6 +1883,45 @@ def parse_address_preceded_by_type(data, offset): | |||
| address_type = data[offset - 1] | |||
| return Address.parse_address_with_type(data, offset, address_type) | |||
|
|
|||
| @classmethod | |||
| def generate_static(cls) -> Address: | |||
There was a problem hiding this comment.
We should try to be consistent in the naming of these 3 methods.
To be very clear, even if a bit long, the full names would be:
generate_static_address, generate_non_resolvable_private_address, and generate_resolvable_private_address. (we can omit the term random here I think since we only generate random addresses).
An alternative would be to drop the _address suffix. But in any case, these methods should either all have the _address suffix, or none of them should have it.
barbibulle
approved these changes
Dec 23, 2023
zxzxwu
changed the title
barbibulle
approved these changes
Dec 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.