Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setup_data_path for iso queues #648

Merged
merged 5 commits into from
Feb 18, 2025
Merged

Add setup_data_path for iso queues #648

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8761129
Add setup_data_path for iso queues
pstrueb Feb 16, 2025
f526f54
refractoring
pstrueb Feb 17, 2025
4b66a38
Refractoring again
pstrueb Feb 17, 2025
ae5f9cf
Remove little accident
pstrueb Feb 17, 2025
185d5fd
reformatting
pstrueb Feb 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions apps/auracast.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -965,6 +965,11 @@ async def run_transmit(
bumble.device.IsoPacketStream(big.bis_links[1], 64),
]

for queue in iso_queues:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching that. Somehow this got accidentally removed in a recent PR and went unnoticed (it still worked with the BT controller on my Pixel phone...).
However, it might be more straightforward to express this as:

for bis_link in big.bis_links:
    await bis_link.setup_data_path(
        direction=bis_link.Direction.HOST_TO_CONTROLLER
)

above line 963

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, will do

await queue.iso_link.setup_data_path(
direction=queue.iso_link.Direction.HOST_TO_CONTROLLER
)

def on_flow():
data_packet_queue = iso_queues[0].data_packet_queue
print(
Expand Down
Loading