Merge pull request #3384 from frebib/bug/verbosity

Go 1.21 compatibility: Set verbosity after flag definition
google · Oct 7, 2023 · 4c67f45 · 4c67f45
2 parents 28d5bdd + 20317bf
commit 4c67f45
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/cmd/cadvisor.go b/cmd/cadvisor.go
@@ -100,14 +100,13 @@ func init() {
 	optstr := container.AllMetrics.String()
 	flag.Var(&ignoreMetrics, "disable_metrics", fmt.Sprintf("comma-separated list of `metrics` to be disabled. Options are %s.", optstr))
 	flag.Var(&enableMetrics, "enable_metrics", fmt.Sprintf("comma-separated list of `metrics` to be enabled. If set, overrides 'disable_metrics'. Options are %s.", optstr))
-
-	// Default logging verbosity to V(2)
-	_ = flag.Set("v", "2")
 }
 
 func main() {
 	klog.InitFlags(nil)
 	defer klog.Flush()
+	// Default logging verbosity to V(2)
+	_ = flag.Set("v", "2")
 	flag.Parse()
 
 	if *versionFlag {