Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop nvml from cadvisor and k/k #3205

Closed
pacoxu opened this issue Dec 1, 2022 · 5 comments
Closed

drop nvml from cadvisor and k/k #3205

pacoxu opened this issue Dec 1, 2022 · 5 comments

Comments

@pacoxu
Copy link
Contributor

pacoxu commented Dec 1, 2022

DisableAcceleratorUsageMetrics is GAed in Kubernetes v1.25. So container.AcceleratorUsageMetrics will not be included anymore by kubelet.

See kubernetes/kubernetes#114204 (comment).

Another issue is opened to replace mindprince/gonvml.

Link all other nvml related issues:

@pacoxu
Copy link
Contributor Author

pacoxu commented Dec 1, 2022

/cc @dashpole
Should we drop all code under https://github.com/google/cadvisor/tree/master/accelerators?

@dashpole
Copy link
Collaborator

dashpole commented Dec 1, 2022

Is it possible to keep it, but not include it in the go module imported by k/k?

@dashpole
Copy link
Collaborator

dashpole commented Dec 1, 2022

Some users may be using it with stand-alone cAdvisor

@pacoxu
Copy link
Contributor Author

pacoxu commented Dec 2, 2022

#3206 will fix this.

Some users may be using it with stand-alone cAdvisor

#3206 (comment) @bobbypage suggests:

For cAdvisor users, we can recommend users to use https://github.com/NVIDIA/dcgm-exporter for accelerator metrics.

@pacoxu
Copy link
Contributor Author

pacoxu commented Dec 2, 2022

per #3206

@pacoxu pacoxu closed this as completed Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants