Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop accelerator metrics and nvidia implementation #3206

Merged
merged 1 commit into from
Dec 2, 2022

Conversation

liggitt
Copy link
Contributor

@liggitt liggitt commented Dec 1, 2022

This capability is unused as of Kubernetes 1.25+ (see kubernetes/kubernetes#114204 (comment) and https://github.com/kubernetes/enhancements/tree/master/keps/sig-node/1867-disable-accelerator-usage-metrics)

That means nvidiaManager was always a no-op implementation in Kubernetes 1.25+

This drops the nvidia implementation, collector, and AcceleratorUsageMetrics stats type, which also allows dropping the github.com/mindprince/gonvml dependency, which some license scanners were unhappy with (xref https://groups.google.com/g/kubernetes-sig-architecture/c/dsMVIdPPUK8/m/u3ZjJtcnBwAJ?utm_medium=email&utm_source=footer)

cc @dashpole @bobbypage

@k8s-ci-robot
Copy link
Collaborator

Hi @liggitt. Thanks for your PR.

I'm waiting for a google member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bobbypage
Copy link
Collaborator

/ok-to-test

@bobbypage
Copy link
Collaborator

Thanks @liggitt, I agree it makes sense that we can drop accelerator metrics after k8s has deprecated in-tree accelerator metrics and drop this dependency.

For cAdvisor users, we can recommend users to use https://github.com/NVIDIA/dcgm-exporter for accelerator metrics.

@bobbypage
Copy link
Collaborator

LGTM

@bobbypage bobbypage merged commit a52ec5d into google:master Dec 2, 2022
@liggitt
Copy link
Contributor Author

liggitt commented Dec 2, 2022

thanks, let's plan to tag cadvisor and bump in k/k early in the 1.27 cycle

@bobbypage
Copy link
Collaborator

bobbypage commented Dec 2, 2022

Sounds good, will do!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants