-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop accelerator metrics and nvidia implementation #3206
Conversation
Hi @liggitt. Thanks for your PR. I'm waiting for a google member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
Thanks @liggitt, I agree it makes sense that we can drop accelerator metrics after k8s has deprecated in-tree accelerator metrics and drop this dependency. For cAdvisor users, we can recommend users to use https://github.com/NVIDIA/dcgm-exporter for accelerator metrics. |
LGTM |
thanks, let's plan to tag cadvisor and bump in k/k early in the 1.27 cycle |
Sounds good, will do! |
The code was removed in google#3206.
This capability is unused as of Kubernetes 1.25+ (see kubernetes/kubernetes#114204 (comment) and https://github.com/kubernetes/enhancements/tree/master/keps/sig-node/1867-disable-accelerator-usage-metrics)
That means nvidiaManager was always a no-op implementation in Kubernetes 1.25+
This drops the nvidia implementation, collector, and AcceleratorUsageMetrics stats type, which also allows dropping the github.com/mindprince/gonvml dependency, which some license scanners were unhappy with (xref https://groups.google.com/g/kubernetes-sig-architecture/c/dsMVIdPPUK8/m/u3ZjJtcnBwAJ?utm_medium=email&utm_source=footer)
cc @dashpole @bobbypage