Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add storage_driver_buffer_duration in Influxdb storage docs #1594

Merged
merged 4 commits into from
Sep 11, 2020

Conversation

matcornic
Copy link
Contributor

No description provided.

@k8s-ci-robot
Copy link
Collaborator

Hi @matcornic. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with @k8s-bot ok to test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@googlebot
Copy link
Collaborator

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@matcornic
Copy link
Contributor Author

I signed it!

@googlebot
Copy link
Collaborator

CLAs look good, thanks!

@dashpole
Copy link
Collaborator

@k8s-bot ok to test

@dashpole
Copy link
Collaborator

@k8s-bot test this

@dashpole
Copy link
Collaborator

I would prefer if you used the same description as in storage/common_flags.go, just to be consistent. This will have to rebase before it can go in.

@dashpole
Copy link
Collaborator

dashpole commented Apr 4, 2017

please squash, and we can get this merged!

@dashpole dashpole closed this Sep 11, 2020
@dashpole dashpole reopened this Sep 11, 2020
@dashpole
Copy link
Collaborator

/retest

@dashpole dashpole merged commit f17af50 into google:master Sep 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants