Reduce log spam when unable to get network stats #1700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @sjenning |
dashpole
approved these changes
Jul 21, 2017
|
@dashpole - the customer reported this was putting their root partition at risk, but in theory the should be able to monitor logs separately. i want to avoid similar reports in the future, so just knowing this is lgtm from you is fine. i would like the version of cadvisor we have w/ kube 1.8 has this fix. |
|
/retest |
|
/test pull-cadvisor-e2e |
|
oh sorry, you need to rebase |
|
rebasing... |
derekwaynecarr
force-pushed
the
reduce-log-spam
branch
from
805a241
to
d493f11
Compare
|
@dashpole -- rebased, simple review. |
openshift-merge-robot
added a commit
to openshift/origin
that referenced
this pull request
Sep 7, 2017
Automatic merge from submit-queue (batch tested with PRs 14825, 15756, 16178, 16188, 16189) UPSTREAM: google/cadvisor: 1700: Reduce log spam when unable to get network stats google/cadvisor#1700 xref https://bugzilla.redhat.com/show_bug.cgi?id=1328913 @derekwaynecarr
|
@derekwaynecarr @dashpole Do you have any idea about why it happened? I saw so much log but can not find any process match the Pids. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have multiple reports of this spamming logs and causing stability issues.
suspect the container process has exited but the cgroup still remained.