-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CRI-O: fix handling of overlay2 storage #1771
Conversation
👍 |
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
well, i hit the wrong button... @runcom -- can you drop my merge branch and rebase on master? |
fyi @sjenning |
f358f8b
to
3d58d31
Compare
@derekwaynecarr done |
/test pull-cadvisor-e2e |
I plan to cut v0.27.2 to cherrypick #1770 into kubernetes 1.8.2. |
This should be included yeah |
Signed-off-by: Antonio Murdaca <runcom@redhat.com>
3d58d31
to
088aaf1
Compare
/test-/test pull-cadvisor-e2e |
@dashpole -- any idea why test results are not reporting? |
looks like it is just waiting on the CLA? Edit: Oh, it wont change from that state. Not sure why the other tests are not running |
The bot says maintainers should check that and merge cause it's not going to, read comment from bot above |
Verified we're now reading the
diff
dir in container's storage:@derekwaynecarr @mrunalp @dashpole PTAL
related to #1770
Signed-off-by: Antonio Murdaca runcom@redhat.com