Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRI-O: fix handling of overlay2 storage #1771

Merged
merged 1 commit into from
Oct 23, 2017

Conversation

runcom
Copy link
Contributor

@runcom runcom commented Oct 13, 2017

Verified we're now reading the diff dir in container's storage:

      "rootfs": {
       "time": "2017-10-13T08:27:45Z",
       "availableBytes": 10798333952,
       "capacityBytes": 52710469632,
       "usedBytes": 90112,
       "inodesFree": 2659325,
       "inodes": 3276800,
       "inodesUsed": 16
      },
[root@runcom 4f4cc46320d76a12e9a833a7708ad62d5d5c8359911553cb3a25e0b12d6c3f75]# pwd
/var/lib/containers/storage/overlay2/4f4cc46320d76a12e9a833a7708ad62d5d5c8359911553cb3a25e0b12d6c3f75
[root@runcom 4f4cc46320d76a12e9a833a7708ad62d5d5c8359911553cb3a25e0b12d6c3f75]# du -s -B1 ./diff/
90112   ./diff/

@derekwaynecarr @mrunalp @dashpole PTAL

related to #1770

Signed-off-by: Antonio Murdaca runcom@redhat.com

@mrunalp
Copy link
Collaborator

mrunalp commented Oct 13, 2017

👍

@googlebot
Copy link
Collaborator

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this State. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@derekwaynecarr
Copy link
Collaborator

well, i hit the wrong button... @runcom -- can you drop my merge branch and rebase on master?

@derekwaynecarr
Copy link
Collaborator

fyi @sjenning

@runcom
Copy link
Contributor Author

runcom commented Oct 18, 2017

@derekwaynecarr done

@derekwaynecarr
Copy link
Collaborator

/test pull-cadvisor-e2e

@dashpole
Copy link
Collaborator

I plan to cut v0.27.2 to cherrypick #1770 into kubernetes 1.8.2.
Should this PR be included as well? @derekwaynecarr

@runcom
Copy link
Contributor Author

runcom commented Oct 21, 2017

This should be included yeah

Signed-off-by: Antonio Murdaca <runcom@redhat.com>
@derekwaynecarr
Copy link
Collaborator

/test-/test pull-cadvisor-e2e

@derekwaynecarr
Copy link
Collaborator

@dashpole -- any idea why test results are not reporting?

@dashpole
Copy link
Collaborator

dashpole commented Oct 23, 2017

looks like it is just waiting on the CLA? Edit: Oh, it wont change from that state. Not sure why the other tests are not running

@runcom
Copy link
Contributor Author

runcom commented Oct 23, 2017

The bot says maintainers should check that and merge cause it's not going to, read comment from bot above

@dashpole dashpole merged commit 99716b0 into google:master Oct 23, 2017
@runcom runcom deleted the fix-overlay2-crio branch October 23, 2017 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants