Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

container: crio: change crio socket #1773

Merged
merged 1 commit into from
Nov 14, 2017

Conversation

runcom
Copy link
Contributor

@runcom runcom commented Oct 18, 2017

@derekwaynecarr
Copy link
Collaborator

to support a smooth transition, can we check for one, and then the other?

Signed-off-by: Antonio Murdaca <runcom@redhat.com>
@dashpole
Copy link
Collaborator

@derekwaynecarr should this be cherrypicked to the kubernetes 1.8.2 release along with #1770?

@dashpole
Copy link
Collaborator

FYI, I plan to cut cadvisor v0.28.1, which will correspond to k8s v1.9.0 this Friday, 11/17.

@derekwaynecarr
Copy link
Collaborator

@dashpole -- this can correspond to 1.9, @runcom - can you confirm the 1.9 cri-o packaging is in the new location?

@runcom
Copy link
Contributor Author

runcom commented Nov 14, 2017

can you confirm the 1.9 cri-o packaging is in the new location?

yeah, the plan is to move to /var/run/crio/crio.sock for 1.9 (we're at 1.8 still)

@runcom
Copy link
Contributor Author

runcom commented Nov 14, 2017

CRI-O PR is here now cri-o/cri-o#1154

@derekwaynecarr derekwaynecarr merged commit 49e0496 into google:master Nov 14, 2017
@derekwaynecarr
Copy link
Collaborator

@dashpole -- this should only go in kube 1.9 tracking releases and not kube 1.8 prior streams.

@runcom runcom deleted the crio-socket-edit branch November 14, 2017 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants