Move from glog to klog #2091
Merged
Move from glog to klog #2091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dims
force-pushed
the
move-from-glog-to-klog
branch
3 times, most recently
from
3a19680
to
f7539b5
Compare
|
related to kubernetes/kubernetes#70264 |
|
Note that this should wait until after 1.32.0 is cut |
dims
force-pushed
the
move-from-glog-to-klog
branch
2 times, most recently
from
badda16
to
7b7f129
Compare
dashpole
reviewed
Nov 8, 2018
cadvisor.go
Outdated
| @@ -34,8 +34,8 @@ import ( | |||
|
|
|||
| "crypto/tls" | |||
|
|
|||
| "github.com/golang/glog" | |||
| "github.com/google/cadvisor/metrics" | |||
| "github.com/google/cadvisor/metrics" | |||
There was a problem hiding this comment.
this looks strange. I am surprised it passes go lint? If you put a new line between these, does it go away?
Change-Id: Ic92f57c2d7f268d8d985797974883c1a537d6993
dims
force-pushed
the
move-from-glog-to-klog
branch
from
7b7f129
to
4da6d80
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving to the new forked repository : k8s.io/klog