Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use current Docker registry #2590

Merged
merged 1 commit into from
Aug 13, 2020
Merged

Use current Docker registry #2590

merged 1 commit into from
Aug 13, 2020

Conversation

dhoppe
Copy link
Contributor

@dhoppe dhoppe commented Jun 19, 2020

No description provided.

@googlebot
Copy link
Collaborator

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@k8s-ci-robot
Copy link
Collaborator

Hi @dhoppe. Thanks for your PR.

I'm waiting for a google member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dhoppe
Copy link
Contributor Author

dhoppe commented Jun 19, 2020

@googlebot I signed it!

@googlebot
Copy link
Collaborator

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@dashpole
Copy link
Collaborator

can you instead update it to point to gcr.io/cadvisor/cadvisor? We recently changed the repo we push images to. Thanks!

/ok-to-test

@dhoppe
Copy link
Contributor Author

dhoppe commented Jun 20, 2020

I see:

In that case I also fixed the README.md.

@dashpole dashpole self-assigned this Aug 13, 2020
Copy link
Collaborator

@dashpole dashpole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@dashpole dashpole merged commit dfe2477 into google:master Aug 13, 2020
bobbypage added a commit to bobbypage/docs that referenced this pull request Dec 30, 2020
cAdvisor registry has moved from GCP project `google_containers` to `cadvisor`, ref: google/cadvisor#2590
bobbypage added a commit to bobbypage/docs that referenced this pull request Dec 30, 2020
cAdvisor registry has moved from GCP project `google_containers` to `cadvisor`, ref: google/cadvisor#2590
bobbypage added a commit to bobbypage/docs that referenced this pull request Dec 30, 2020
cAdvisor registry has moved from GCP project `google_containers` to `cadvisor`, ref: google/cadvisor#2590

Signed-off-by: David Porter <david@porter.me>
brian-brazil pushed a commit to prometheus/docs that referenced this pull request Dec 30, 2020
cAdvisor registry has moved from GCP project `google_containers` to `cadvisor`, ref: google/cadvisor#2590

Signed-off-by: David Porter <david@porter.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants