Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix runtime error when there are no NVM devices. #2676

Merged
merged 1 commit into from
Oct 16, 2020
Merged

Fix runtime error when there are no NVM devices. #2676

merged 1 commit into from
Oct 16, 2020

Conversation

Creatone
Copy link
Collaborator

Fixes #2675

@k8s-ci-robot
Copy link
Collaborator

Hi @Creatone. Thanks for your PR.

I'm waiting for a google member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Fix runtime error when there are no NVM devices.
05812f0 
Signed-off-by: Paweł Szulik <pawel.szulik@intel.com>
@google-cla google-cla bot added the cla: yes label Sep 21, 2020
@katarzyna-z katarzyna-z mentioned this pull request Oct 5, 2020
Merged
@iwankgb
Copy link
Collaborator

iwankgb commented Oct 9, 2020

/ok-to-test

@iwankgb
Copy link
Collaborator

iwankgb commented Oct 16, 2020

@dashpole could you merge it, please? It proves that docker-based integration tests must be fixed (and causes failures in #2691).

dashpole
dashpole approved these changes Oct 16, 2020
View reviewed changes
Copy link
Collaborator

@dashpole dashpole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dashpole dashpole merged commit 5e4680a into google:master Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dashpole dashpole dashpole approved these changes

Assignees
No one assigned
Labels
cla: yes ok-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Runtime error when there are no NVM devices.
4 participants
@Creatone @k8s-ci-robot @iwankgb @dashpole