Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move mount library dependency from utils/mount to mount-utils #2687

Merged
merged 1 commit into from
Oct 9, 2020

Conversation

brahmaroutu
Copy link
Contributor

This PR is updating the dependency for the mount library. We have recently moved utils/mount to mount-utils under the repo https://github.com/kubernetes/mount-utils. This library is now available for kubernetes/kubernetes components under staging/src/k8s.io/mount-utils. Go module being k8s.io/mount-utils
Going forward, mount library will not be maintained under the repo https://github.com/kubernetes/utils.

@google-cla google-cla bot added the cla: yes label Oct 2, 2020
@k8s-ci-robot
Copy link
Collaborator

Hi @brahmaroutu. Thanks for your PR.

I'm waiting for a google member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@brahmaroutu
Copy link
Contributor Author

Not sure who could review, but looking at the latest commits, @dashpole @iwankgb can you please help here?
This PR is important for us to remove dependency on utils/mount. This is the only module in kubernetes/kubernetes which is dependent on utils/mount and blocking our progress.

@iwankgb
Copy link
Collaborator

iwankgb commented Oct 9, 2020

/ok-to-test

@iwankgb
Copy link
Collaborator

iwankgb commented Oct 9, 2020

@brahmaroutu, I had no idea that I can use commands here.

@iwankgb
Copy link
Collaborator

iwankgb commented Oct 9, 2020

lgtm

@iwankgb
Copy link
Collaborator

iwankgb commented Oct 9, 2020

@brahmaroutu I do not have all the superpowers, though. I can't merge it :(

Copy link
Collaborator

@dashpole dashpole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dashpole dashpole merged commit 013e451 into google:master Oct 9, 2020
@brahmaroutu
Copy link
Contributor Author

Awesome, thank you @iwankgb and @dashpole for the review.

@dashpole
Copy link
Collaborator

@brahmaroutu we can't actually depend on a staging library in cAdvisor since cAdvisor is vendored into the kubelet. This will have to be reverted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants