Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add space trimming for label allowlist #3325

Merged

Conversation

oif
Copy link
Contributor

@oif oif commented Jun 11, 2023

Some developers prefer to write lists by adding spaces after commas, so add handling of spaces to increase code robustness

@google-cla
Copy link

google-cla bot commented Jun 11, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@k8s-ci-robot
Copy link
Collaborator

Hi @oif. Thanks for your PR.

I'm waiting for a google member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@iwankgb
Copy link
Collaborator

iwankgb commented Jun 11, 2023

/ok-to-test

@iwankgb
Copy link
Collaborator

iwankgb commented Jun 11, 2023

Blocked by #3304 (8794bc9).

Some developers prefer to write lists by adding spaces after commas,
so add handling of spaces to increase code robustness
@oif oif force-pushed the fix/add-space-trimming-for-label-allow-list branch from 19e5c95 to 99502b0 Compare June 26, 2023 01:59
@oif
Copy link
Contributor Author

oif commented Jun 26, 2023

ping @iwankgb

@iwankgb iwankgb merged commit 0a9c9fa into google:master Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants