Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update zoneinfo files to 2024b #298

Closed
wants to merge 4 commits into from
Closed

Conversation

devbww
Copy link
Contributor

@devbww devbww commented Sep 9, 2024

No description provided.

Copy link

google-cla bot commented Sep 9, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@derekmauro
Copy link
Member

Thanks! I started working on this on Friday as well.

There is a test failure in TimeZoneEdgeCase.WET. I looks like WET was made an alias for Europe/Lisbon, almost as an arbitrary choice of replacement. But that removes the edge cases tested by TimeZoneEdgeCase.WET. I haven't looked to see if that means we are losing test coverage for the non-existent transitions tested by TimeZoneEdgeCase.WET, and if we need to replace them by other non-existent transitions for coverage.

@devbww
Copy link
Contributor Author

devbww commented Sep 9, 2024

There is a test failure in TimeZoneEdgeCase.WET. I looks like WET was made an alias for Europe/Lisbon, almost as an arbitrary choice of replacement.

Sigh. I don't know why the upstream stuff has to be so unstable. Oh well.

But that removes the edge cases tested by TimeZoneEdgeCase.WET. I haven't looked to see if that means we are losing test coverage for the non-existent transitions tested by TimeZoneEdgeCase.WET, and if we need to replace them by other non-existent transitions for coverage.

I don't think we're losing any coverage, and that the test could well be removed. But to err on the side of caution, I'll propose a test tweak instead.

Unfortunately, I am currently not in the position to build/test anything, so I could easily get things wrong. I guess we'll see if it turns green. But also given that inability, please feel free to ignore this PR altogether and move forward with your stuff. I was only hoping to make the CCTZ size of things easier, but until I can build/test again I may well be making it worse. :-(

@derekmauro
Copy link
Member

Unfortunately, I am currently not in the position to build/test anything, so I could easily get things wrong. I guess we'll see if it turns green. But also given that inability, please feel free to ignore this PR altogether and move forward with your stuff. I was only hoping to make the CCTZ size of things easier, but until I can build/test again I may well be making it worse. :-(

I got so tired of Kokoro constantly breaking, and with the possibility of losing such a valuable contributor, I added GitHub Actions in 6624659. If you want to rebase onto or merge 6624659, I think the tests should just work for you. I'll delete the Kokoro tests shortly.

@devbww devbww closed this Sep 9, 2024
@devbww devbww deleted the tz2024b branch September 9, 2024 19:48
@devbww
Copy link
Contributor Author

devbww commented Sep 9, 2024

I'll open a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants