Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecation notice recommends nonexistent replacement #837

Closed
akshayjshah opened this issue Sep 8, 2023 · 1 comment · Fixed by #840
Closed

Deprecation notice recommends nonexistent replacement #837

akshayjshah opened this issue Sep 8, 2023 · 1 comment · Fixed by #840
Assignees
@TristonianJones

Comments

@akshayjshah
Copy link

Describe the bug

cel.OptCheckStringFormat is deprecated, directing users to ext.ValidateFormatString(). However, ext.ValidateFormatString doesn't seem to exist. Should this deprecation notice be pointing to ext.StringsValidateFormatCalls instead?

To Reproduce
N/A

Expected behavior
N/A

Additional context
None :)
@akshayjshah akshayjshah mentioned this issue Sep 8, 2023
Closed
akshayjshah added a commit to bufbuild/protovalidate-go that referenced this issue Sep 8, 2023
@akshayjshah
Bypass deprecation lint warning
4a6cad0 
CI is failing because of a deprecation notice on
`cel.OptCheckStringFormat`, but the recommended alternative doesn't
appear to exist. I've filed google/cel-go#837
upstream to clarify, but for now tests are passing so I think we can
safely bypass this lint error.

I also filed #44 so
that we don't forget to migrate to whichever API is recommended and
remove this bypass.
@akshayjshah akshayjshah mentioned this issue Sep 8, 2023
Merged
@TristonianJones
Copy link
Collaborator

@akshayjshah thanks, good catch. I'll update the notice.

@TristonianJones TristonianJones self-assigned this Sep 8, 2023
rodaine pushed a commit to bufbuild/protovalidate-go that referenced this issue Sep 12, 2023
@akshayjshah
Bypass deprecation lint warning (#45)
33692a1 
CI is failing because of a deprecation notice on
`cel.OptCheckStringFormat`, but the recommended alternative doesn't
appear to exist. I've filed google/cel-go#837
upstream to clarify, but for now tests are passing so I think we can
safely bypass this lint error.

I also filed #44 so
that we don't forget to migrate to whichever API is recommended and
remove this bypass.
@TristonianJones TristonianJones mentioned this issue Sep 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TristonianJones TristonianJones

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix deprecation notice for string format validation TristonianJones/cel-go
2 participants
@TristonianJones @akshayjshah