Policy nested rule fix #1092
Merged
Policy nested rule fix #1092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Better support for fall-through on optional.none() cases from parent rules as the notion of a `none` value should signify that no branch condition is satisfied, and thus other branches should be able to assess the rule. In some cases the `orValue` usage is a little unusual, in that it can wrap a ternary containing an optional return value, but such cases only occur when the rule always returns an output and they behave correctly.
TristonianJones
force-pushed
the
policy-nested-rule-fix
branch
from
4466f35 to
65d758f
Compare
seirl
previously approved these changes
Dec 10, 2024
l46kok
reviewed
Dec 10, 2024
l46kok
previously approved these changes
Dec 11, 2024
l46kok
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More robust handling for optional / non-optional policy outputs.
Closes #1087