Add strings.quote #639
Merged
Add strings.quote #639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/gcbrun |
Merged
cici37
reviewed
Feb 15, 2023
|
/gcbrun |
DangerOnTheRanger
force-pushed
the
string-escape
branch
from
77eed43 to
e912ebb
Compare
jpbetz
reviewed
Feb 23, 2023
DangerOnTheRanger
force-pushed
the
string-escape
branch
from
e912ebb to
64a2a5e
Compare
|
/gcbrun |
TristonianJones
approved these changes
Mar 10, 2023
|
/gcbrun |
|
Please version gate this and add version test case. |
TristonianJones
requested changes
Mar 10, 2023
jpbetz
reviewed
Mar 10, 2023
|
Please add runtime and estimated costs. |
jpbetz
reviewed
Mar 11, 2023
|
/gcbrun |
TristonianJones
approved these changes
Mar 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
strings.quote, which is intended to quote escape sequences mentioned in the CEL spec and allow the output to be safely copy-pasted into a CEL expression.