Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Appengine demo #646

Merged
merged 10 commits into from
Mar 22, 2023
Merged

Appengine demo #646

merged 10 commits into from
Mar 22, 2023

Conversation

jnthntatum
Copy link
Collaborator 

Add a simple web interface for the repl and accompanying JSON API

This adds a simple, google app engine compatible web frontend for the repl for ease of use.
Allows for easier input and display for sessions with the REPL.

@jnthntatum
Copy link
Collaborator Author

@TristonianJones @l46kok: what do you think? Let me know if you think this is worth fleshing out and of any changes you'd like to see to include it.

l46kok
l46kok reviewed Feb 28, 2023
View reviewed changes
Copy link
Collaborator

@l46kok l46kok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks great, just a few non-binding suggestions:

repl/appengine/app/api.go Show resolved Hide resolved
repl/appengine/web/src/app/repl-console/repl-console.component.html Outdated Show resolved Hide resolved
repl/appengine/web/src/app/repl-console/repl-result-detail.component.html Show resolved Hide resolved
repl/appengine/web/src/app/repl-console/repl-console.component.html Outdated Show resolved Hide resolved
repl/appengine/app.yaml Show resolved Hide resolved
@jnthntatum
Copy link
Collaborator Author

Addressed the initial feedback

l46kok
l46kok reviewed Mar 3, 2023
View reviewed changes
repl/appengine/README.md Outdated Show resolved Hide resolved
repl/appengine/README.md Outdated Show resolved Hide resolved
repl/appengine/README.md Outdated Show resolved Hide resolved
repl/appengine/web/src/app/app.component.spec.ts Outdated Show resolved Hide resolved
TristonianJones
TristonianJones previously approved these changes Mar 9, 2023
View reviewed changes
Copy link
Collaborator

@TristonianJones TristonianJones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a really great skin / app over the repl. I'm excited for its existence and also to refine the UI over time.

@jnthntatum jnthntatum force-pushed the appengine-demo branch 2 times, most recently from 034c131 to 16b001e Compare March 13, 2023 19:23
@jnthntatum jnthntatum marked this pull request as ready for review March 13, 2023 21:24
l46kok
l46kok previously approved these changes Mar 14, 2023
View reviewed changes
@jnthntatum jnthntatum dismissed stale reviews from l46kok and TristonianJones via 32d97b2 March 22, 2023 22:05
@jnthntatum jnthntatum merged commit e483419 into google:master Mar 22, 2023
@jnthntatum jnthntatum deleted the appengine-demo branch June 14, 2023 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TristonianJones TristonianJones TristonianJones approved these changes

@l46kok l46kok l46kok left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jnthntatum @TristonianJones @l46kok