Prune recursion fixes for nested logic #677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In expressions where the logic is nested and the residual state would result in the production of a constant value in the expression, ensure that the intermediate state for the expression is updated to reflect the constant value. Also, ensure that special cases of pruning for logical operators happen after argument pruning has happened to ensure that the prune steps are properly recursive.
jcking
approved these changes
Apr 6, 2023
TristonianJones
added a commit
to TristonianJones/cel-go
that referenced
this pull request
Apr 12, 2023
In expressions where the logic is nested and the residual state would result in the production of a constant value in the expression, ensure that the intermediate state for the expression is updated to reflect the constant value. Also, ensure that special cases of pruning for logical operators happen after argument pruning has happened to ensure that the prune steps are properly recursive.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In expressions where the logic is nested and the residual state would result in the production of a constant value in the expression, ensure that the intermediate state for the expression is updated to reflect the constant value.
Also, ensure that special cases of pruning for logical operators happen after argument pruning has happened to ensure that the prune steps are properly recursive.