Update the ConvertToNative API documentation and strings.join #692
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the
ConvertToNative
API docs to clarify the call contract.The change also introduces a refactor of the
strings.join
method whichdoes not rely on
ConvertToNative
, but rather uses thetraits.Lister
withan expectation that all contained elements will be
types.String
values.This change can be taken advantage of using
ext.StringsVersion(2)
ifyou are using extension versioning. If you are not using extension versioning,
the change will be default enabled.
The functionality should be equivalent with the prior behavior, though there
are some limited cases where a
ConvertToNative
might succeed whenthe new approach might fail.
Closes #688