Additional string.format() test for message field accesses #694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TristonianJones
changed the title
…acking and correlation to type ids from checked expressions
|
FYI @jpbetz |
jpbetz
approved these changes
May 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refined the test approach in
ext/strings_test.goto better cover type-based validation of format args.Fixed an issue where attribute ids were referring to the variable id rather than the leaf value of the attribute.
This has a minor impact on attribute state tracking which should not affect semantic meaning, but which
does have a real impact on whether or not the attribute expression corresponds to the type identifier in
the
checked.prototype_mapfield.Closes #690