Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the overload reference for optional field selection #730

Merged

Conversation

TristonianJones
Copy link
Collaborator

Ensure that the overload id is set on the optional field selection call, e.g. a.?b.

Additionally, update the overload id to more accurately reflect the argument types.
This overload id change is backwards compatible since the interpreter special cases
handling based on the function name in these situations, and none of the other
runtimes currently support the new overloads yet.

@TristonianJones TristonianJones requested a review from l46kok June 7, 2023 22:43
@TristonianJones TristonianJones merged commit 3535f7a into google:master Jun 8, 2023
@TristonianJones TristonianJones deleted the optional-overload-ids branch June 8, 2023 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants