Validators for common literals and use cases #765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TristonianJones
commented
Jul 6, 2023
There was a problem hiding this comment.
@DangerOnTheRanger @jpbetz @cici37 What do you think of the validator support being added here? I 'll update the string formatting checks to happen immediately after type-check in a subsequent PR, but I wanted to showcase what could be done with the latest improvements. I'm also tempted to update the checker cost model to use the new NavigableExpr type since it's more thorough than the decorators and easier to manage. Thoughts?
This PR will be introduced after #762 is reviewed and submitted.
TristonianJones
force-pushed
the
ast-validate
branch
5 times, most recently
from
308ea29 to
3fbbe99
Compare
Introduce validators for duration, timestamp, and regex string literals as well as support for homogeneous aggregate literals with a carveout for string format calls.
TristonianJones
force-pushed
the
ast-validate
branch
from
3fbbe99 to
4b3a5ef
Compare
l46kok
reviewed
Jul 10, 2023
l46kok
approved these changes
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce validators for duration, timestamp, and regex string literals as well as support for homogeneous aggregate literals with a carve-out for string format calls.
Closes #359
Closes #496
Closes #655