Comprehension nesting limit validator #769
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a comprehension nesting limit validator which checks to see
if more than
limit
non-trivial comprehensions are nested within eachother.
A trivial comprehension is one in which the
iterRange
is an empty list,such as occurs during
cel.bind()
calls. The computational overheadof these kinds of comprehension ASTs is nominal and should be covered
by cost estimation toolilng.
Closes #420