Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comprehension nesting limit validator #769

Merged
merged 1 commit into from
Jul 10, 2023

Conversation

TristonianJones
Copy link
Collaborator

@TristonianJones TristonianJones commented Jul 7, 2023

Introduce a comprehension nesting limit validator which checks to see
if more than limit non-trivial comprehensions are nested within each
other.

A trivial comprehension is one in which the iterRange is an empty list,
such as occurs during cel.bind() calls. The computational overhead
of these kinds of comprehension ASTs is nominal and should be covered
by cost estimation toolilng.

Closes #420

@TristonianJones TristonianJones marked this pull request as ready for review July 10, 2023 21:13
@TristonianJones TristonianJones merged commit a13553b into google:master Jul 10, 2023
@TristonianJones TristonianJones deleted the nesting-limit branch July 10, 2023 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose a Restriction for Compiling Expressions With Nested Macros
2 participants