Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move antlr generated CEL parser to it's own package #194

Merged
merged 1 commit into from
Dec 19, 2023
Merged

move antlr generated CEL parser to it's own package #194

merged 1 commit into from
Dec 19, 2023

Conversation

mikedanese
Copy link
Contributor

This fixes a build failure on MacOS due to path conflict with CelParser.java.

Tested with:

$ bazel build //...
INFO: Analyzed 359 targets (0 packages loaded, 0 targets configured).
INFO: Found 359 targets...
INFO: Elapsed time: 0.148s, Critical Path: 0.00s
INFO: 1 process: 1 internal.
INFO: Build completed successfully, 1 total action

Fixes: #193

@mikedanese
move antlr generated CEL parser to it's own package
784a981 
This fixes a build failure on MacOS due to path conflict with
CelParser.java.
@mikedanese mikedanese mentioned this pull request Dec 14, 2023
Closed
@l46kok l46kok added the ready to pull Pulls the pending PR into Critique label Dec 19, 2023
@copybara-service copybara-service bot merged commit 06cff40 into google:main Dec 19, 2023
3 of 4 checks passed
@mikedanese mikedanese deleted the fix branch December 19, 2023 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@l46kok l46kok l46kok approved these changes

Assignees
No one assigned
Labels
ready to pull Pulls the pending PR into Critique
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Build failure on Mac OSX
2 participants
@mikedanese @l46kok