Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code for Exercise 9 Codelabs #344

Merged
1 commit merged into from
May 9, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions codelab/src/main/codelab/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,12 @@ java_library(
name = "codelab",
srcs = glob(["*.java"]),
deps = [
"//bundle:cel", # unuseddeps: keep
"//common", # unuseddeps: keep
"//common:compiler_common", # unuseddeps: keep
"//common:proto_json_adapter", # unuseddeps: keep
"//common/ast", # unuseddeps: keep
"//common/navigation", # unuseddeps: keep
"//common/types", # unuseddeps: keep
"//common/types:type_providers", # unuseddeps: keep
"//compiler", # unuseddeps: keep
Expand All @@ -24,6 +27,7 @@ java_library(
"//parser:macro", # unuseddeps: keep
"//runtime", # unuseddeps: keep
"//validator", # unuseddeps: keep
"//validator:ast_validator", # unuseddeps: keep
"//validator:validator_builder", # unuseddeps: keep
"//validator/validators:duration", # unuseddeps: keep
"//validator/validators:homogeneous_literal", # unuseddeps: keep
Expand Down
99 changes: 99 additions & 0 deletions codelab/src/main/codelab/Exercise9.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,99 @@
// Copyright 2024 Google LLC
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// https://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

package codelab;

import com.google.rpc.context.AttributeContext;
import dev.cel.common.CelAbstractSyntaxTree;
import dev.cel.common.CelFunctionDecl;
import dev.cel.common.CelOverloadDecl;
import dev.cel.common.CelValidationException;
import dev.cel.common.CelValidationResult;
import dev.cel.common.types.SimpleType;
import dev.cel.compiler.CelCompiler;
import dev.cel.compiler.CelCompilerFactory;
import dev.cel.parser.CelStandardMacro;
import dev.cel.runtime.CelEvaluationException;
import dev.cel.runtime.CelRuntime;
import dev.cel.runtime.CelRuntimeFactory;
import dev.cel.validator.CelValidator;
import dev.cel.validator.CelValidatorFactory;

/**
* Exercise9 demonstrates how to author a custom AST validator to perform domain specific
* validations.
*
* <p>Given a `google.rpc.context.AttributeContext.Request` message, validate that its fields follow
* the expected HTTP specification.
*
* <p>Given an expression containing an expensive function call, validate that it is not nested
* within a macro.
*/
final class Exercise9 {
private static final CelCompiler CEL_COMPILER =
CelCompilerFactory.standardCelCompilerBuilder()
.setStandardMacros(CelStandardMacro.ALL)
.addFunctionDeclarations(
CelFunctionDecl.newFunctionDeclaration(
"is_prime_number",
CelOverloadDecl.newGlobalOverload(
"is_prime_number_int",
"Invokes an expensive RPC call to check if the value is a prime number.",
SimpleType.BOOL,
SimpleType.INT)))
.addMessageTypes(AttributeContext.Request.getDescriptor())
.build();
private static final CelRuntime CEL_RUNTIME =
CelRuntimeFactory.standardCelRuntimeBuilder()
.addMessageTypes(AttributeContext.Request.getDescriptor())
.build();
private static final CelValidator CEL_VALIDATOR =
CelValidatorFactory.standardCelValidatorBuilder(CEL_COMPILER, CEL_RUNTIME)
// Add your custom AST validators here
.build();

/**
* Compiles the input expression.
*
* @throws CelValidationException If the expression contains parsing or type-checking errors.
*/
CelAbstractSyntaxTree compile(String expression) throws CelValidationException {
return CEL_COMPILER.compile(expression).getAst();
}

/** Validates a type-checked AST. */
CelValidationResult validate(CelAbstractSyntaxTree checkedAst) {
return CEL_VALIDATOR.validate(checkedAst);
}

/** Evaluates the compiled AST. */
Object eval(CelAbstractSyntaxTree ast) throws CelEvaluationException {
return CEL_RUNTIME.createProgram(ast).eval();
}

/**
* Performs general validation on AttributeContext.Request message. The validator raises errors if
* the HTTP request is malformed and semantically invalid (e.g: contains disallowed HTTP methods).
* Warnings are presented if there's potential problems with the contents of the request (e.g:
* using "http" instead of "https" for scheme).
*/
static final class AttributeContextRequestValidator {
// Implement validate method here
}

/** Prevents nesting an expensive function call within a macro. */
static final class ComprehensionSafetyValidator {
// Implement validate method here
}
}
4 changes: 4 additions & 0 deletions codelab/src/main/codelab/solutions/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,12 @@ java_library(
name = "solutions",
srcs = glob(["*.java"]),
deps = [
"//bundle:cel",
"//common",
"//common:compiler_common",
"//common:proto_json_adapter",
"//common/ast",
"//common/navigation",
"//common/types",
"//common/types:type_providers",
"//compiler",
Expand All @@ -24,6 +27,7 @@ java_library(
"//parser:macro",
"//runtime",
"//validator",
"//validator:ast_validator",
"//validator:validator_builder",
"//validator/validators:duration",
"//validator/validators:homogeneous_literal",
Expand Down
173 changes: 173 additions & 0 deletions codelab/src/main/codelab/solutions/Exercise9.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,173 @@
// Copyright 2024 Google LLC
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// https://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

package codelab.solutions;

import com.google.common.collect.ImmutableSet;
import com.google.rpc.context.AttributeContext;
import dev.cel.bundle.Cel;
import dev.cel.common.CelAbstractSyntaxTree;
import dev.cel.common.CelFunctionDecl;
import dev.cel.common.CelOverloadDecl;
import dev.cel.common.CelValidationException;
import dev.cel.common.CelValidationResult;
import dev.cel.common.ast.CelExpr;
import dev.cel.common.ast.CelExpr.CelStruct;
import dev.cel.common.ast.CelExpr.ExprKind.Kind;
import dev.cel.common.navigation.CelNavigableAst;
import dev.cel.common.types.SimpleType;
import dev.cel.compiler.CelCompiler;
import dev.cel.compiler.CelCompilerFactory;
import dev.cel.parser.CelStandardMacro;
import dev.cel.runtime.CelEvaluationException;
import dev.cel.runtime.CelRuntime;
import dev.cel.runtime.CelRuntimeFactory;
import dev.cel.validator.CelAstValidator;
import dev.cel.validator.CelValidator;
import dev.cel.validator.CelValidatorFactory;

/**
* Exercise9 demonstrates how to author a custom AST validator to perform domain specific
* validations.
*
* <p>Given a `google.rpc.context.AttributeContext.Request` message, validate that its fields follow
* the expected HTTP specification.
*
* <p>Given an expression containing an expensive function call, validate that it is not nested
* within a macro.
*/
final class Exercise9 {
private static final CelCompiler CEL_COMPILER =
CelCompilerFactory.standardCelCompilerBuilder()
.setStandardMacros(CelStandardMacro.ALL)
.addFunctionDeclarations(
CelFunctionDecl.newFunctionDeclaration(
"is_prime_number",
CelOverloadDecl.newGlobalOverload(
"is_prime_number_int",
"Invokes an expensive RPC call to check if the value is a prime number.",
SimpleType.BOOL,
SimpleType.INT)))
.addMessageTypes(AttributeContext.Request.getDescriptor())
.build();
private static final CelRuntime CEL_RUNTIME =
CelRuntimeFactory.standardCelRuntimeBuilder()
.addMessageTypes(AttributeContext.Request.getDescriptor())
.build();
private static final CelValidator CEL_VALIDATOR =
CelValidatorFactory.standardCelValidatorBuilder(CEL_COMPILER, CEL_RUNTIME)
.addAstValidators(
new AttributeContextRequestValidator(), //
new ComprehensionSafetyValidator())
.build();

/**
* Compiles the input expression.
*
* @throws CelValidationException If the expression contains parsing or type-checking errors.
*/
CelAbstractSyntaxTree compile(String expression) throws CelValidationException {
return CEL_COMPILER.compile(expression).getAst();
}

/** Validates a type-checked AST. */
CelValidationResult validate(CelAbstractSyntaxTree checkedAst) {
return CEL_VALIDATOR.validate(checkedAst);
}

/** Evaluates the compiled AST. */
Object eval(CelAbstractSyntaxTree ast) throws CelEvaluationException {
return CEL_RUNTIME.createProgram(ast).eval();
}

/**
* Performs general validation on AttributeContext.Request message. The validator raises errors if
* the HTTP request is malformed and semantically invalid (e.g: contains disallowed HTTP methods).
* Warnings are presented if there's potential problems with the contents of the request (e.g:
* using "http" instead of "https" for scheme).
*/
static final class AttributeContextRequestValidator implements CelAstValidator {
private static final ImmutableSet<String> ALLOWED_HTTP_METHODS =
ImmutableSet.of("GET", "POST", "PUT", "DELETE");

@Override
public void validate(CelNavigableAst navigableAst, Cel cel, IssuesFactory issuesFactory) {
navigableAst
.getRoot()
.allNodes()
.filter(node -> node.getKind().equals(Kind.STRUCT))
.map(node -> node.expr().struct())
.filter(
struct -> struct.messageName().equals("google.rpc.context.AttributeContext.Request"))
.forEach(
struct -> {
for (CelStruct.Entry entry : struct.entries()) {
String fieldKey = entry.fieldKey();
if (fieldKey.equals("method")) {
String entryStringValue = getStringValue(entry.value());
if (!ALLOWED_HTTP_METHODS.contains(entryStringValue)) {
issuesFactory.addError(
entry.value().id(), entryStringValue + " is not an allowed HTTP method.");
}
} else if (fieldKey.equals("scheme")) {
String entryStringValue = getStringValue(entry.value());
if (!entryStringValue.equals("https")) {
issuesFactory.addWarning(
entry.value().id(), "Prefer using https for safety.");
}
}
}
});
}

/**
* Reads the underlying string value from the expression.
*
* @throws UnsupportedOperationException if the expression is not a constant string value.
*/
private static String getStringValue(CelExpr celExpr) {
return celExpr.constant().stringValue();
}
}

/** Prevents nesting an expensive function call within a macro. */
static final class ComprehensionSafetyValidator implements CelAstValidator {
private static final String EXPENSIVE_FUNCTION_NAME = "is_prime_number";

@Override
public void validate(CelNavigableAst navigableAst, Cel cel, IssuesFactory issuesFactory) {
navigableAst
.getRoot()
.allNodes()
.filter(node -> node.getKind().equals(Kind.COMPREHENSION))
.forEach(
comprehensionNode -> {
boolean isFunctionWithinMacro =
comprehensionNode
.descendants()
.anyMatch(
node ->
node.expr()
.callOrDefault()
.function()
.equals(EXPENSIVE_FUNCTION_NAME));
if (isFunctionWithinMacro) {
issuesFactory.addError(
comprehensionNode.id(),
EXPENSIVE_FUNCTION_NAME + " function cannot be used within CEL macros.");
}
});
}
}
}
16 changes: 16 additions & 0 deletions codelab/src/test/codelab/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,22 @@ java_test(
],
)

java_test(
name = "Exercise9Test",
srcs = ["Exercise9Test.java"],
tags = ["notap"],
test_class = "codelab.Exercise9Test",
deps = [
"//:java_truth",
"//codelab",
"//common",
"//common:compiler_common",
"@maven//:com_google_api_grpc_proto_google_common_protos",
"@maven//:com_google_testparameterinjector_test_parameter_injector",
"@maven//:junit_junit",
],
)

test_suite(
name = "exercise_test_suite",
tags = ["notap"],
Expand Down
Loading
Loading