Enforce composed AST stays below the configured depth limit #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_663089056
branch
2 times, most recently
from
3e75423
to
c3a7528
Compare
PiperOrigin-RevId: 663361547
copybara-service
bot
force-pushed
the
test_663089056
branch
from
c3a7528
to
80baca4
Compare
lqiu96
pushed a commit
to googleapis/sdk-platform-java
that referenced
this pull request
Sep 3, 2024
This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [dev.cel:cel](https://github.com/google/cel-java) | `0.6.0` -> `0.7.1` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>google/cel-java (dev.cel:cel)</summary> ### [`v0.7.1`](https://github.com/google/cel-java/releases/tag/v0.7.1) > \[!IMPORTANT] > [enableUnsignedLongs in CelOptions](https://github.com/google/cel-java/blob/main/common/src/main/java/dev/cel/common/CelOptions.java#L421) is now enabled by default as of [#​410](https://github.com/google/cel-java/commit/78dfcb527526de25e1b5f498bdde6f140c302801). Unsigned integer literals (**uint**) in CEL expressions will now be represented as **com.google.common.primitives.UnsignedLong** instead of **java.lang.Long** when evaluated. If your expressions expose these unsigned integer literals directly or you have custom functions that work with unsigned integers, you may need to explicitly disable this flag and make adjustments to avoid errors. #### Features - Add ListsExtension with flatten function [google/cel-java#427, [#​434](https://github.com/google/cel-java/commit/7398767f80578ae0b23f25d7484dde699b023544) - Introduce ProtoUnsetFieldOptions to support unset handling like C++ in [google/cel-java#403 - Include identity functions in the standard definitions in [google/cel-java#405 - Add string to boolean conversion function in the standard definition in [google/cel-java#407 - Provide an overload to hide all fields on a message with ProtoTypeMask in [google/cel-java#415 - Parse explanations in match blocks in [google/cel-java#420 - Improved support for nested rules in [google/cel-java#422 - Add a validator for enforcing AST depth limit in [google/cel-java#421 - Enforce composed AST stays below the configured depth limit in [google/cel-java#424 - Improve CSE for comprehensions by taking into their nesting level and types into account in [google/cel-java#430 - Add an option to prevent breaking apart a comprehension in CSE in [google/cel-java#432 - Enable retainComprehensionStructure by default in [google/cel-java#436 - Add unreachable checks in policies in [google/cel-java#423 #### Fixes - Do not override the container if it's missing from policy config in [google/cel-java#401 - Add option to specify folding designated custom functions only in [google/cel-java#402 - Fix conditionally nested rules to include its condition in [google/cel-java#404 - Fix runtime equality behavior for sets extension in [google/cel-java#416 - Reduce count of errors joined together during parsing error in [google/cel-java#417 [google/cel-java#418 #### Miscellaneous Changes - Upgrade protobuf version to 4.28.0 in [google/cel-java#439 - Remove unused list/map conversion functions from standard definitions in [google/cel-java#406 - Open source Java conformance tests in [google/cel-java#413 - Change cel_spec repo url to 0.16.0 in WORKSPACE in [google/cel-java#419 - Migrate test_all_types proto over to the cel-spec variant in [google/cel-java#433 **Full Changelog**: google/cel-java@v0.6.0...v0.7.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/googleapis/sdk-platform-java). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC41OS4yIiwidXBkYXRlZEluVmVyIjoiMzguNTkuMiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->
ldetmer
pushed a commit
to googleapis/sdk-platform-java
that referenced
this pull request
Sep 17, 2024
This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [dev.cel:cel](https://github.com/google/cel-java) | `0.6.0` -> `0.7.1` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>google/cel-java (dev.cel:cel)</summary> ### [`v0.7.1`](https://github.com/google/cel-java/releases/tag/v0.7.1) > \[!IMPORTANT] > [enableUnsignedLongs in CelOptions](https://github.com/google/cel-java/blob/main/common/src/main/java/dev/cel/common/CelOptions.java#L421) is now enabled by default as of [#​410](https://github.com/google/cel-java/commit/78dfcb527526de25e1b5f498bdde6f140c302801). Unsigned integer literals (**uint**) in CEL expressions will now be represented as **com.google.common.primitives.UnsignedLong** instead of **java.lang.Long** when evaluated. If your expressions expose these unsigned integer literals directly or you have custom functions that work with unsigned integers, you may need to explicitly disable this flag and make adjustments to avoid errors. #### Features - Add ListsExtension with flatten function [google/cel-java#427, [#​434](https://github.com/google/cel-java/commit/7398767f80578ae0b23f25d7484dde699b023544) - Introduce ProtoUnsetFieldOptions to support unset handling like C++ in [google/cel-java#403 - Include identity functions in the standard definitions in [google/cel-java#405 - Add string to boolean conversion function in the standard definition in [google/cel-java#407 - Provide an overload to hide all fields on a message with ProtoTypeMask in [google/cel-java#415 - Parse explanations in match blocks in [google/cel-java#420 - Improved support for nested rules in [google/cel-java#422 - Add a validator for enforcing AST depth limit in [google/cel-java#421 - Enforce composed AST stays below the configured depth limit in [google/cel-java#424 - Improve CSE for comprehensions by taking into their nesting level and types into account in [google/cel-java#430 - Add an option to prevent breaking apart a comprehension in CSE in [google/cel-java#432 - Enable retainComprehensionStructure by default in [google/cel-java#436 - Add unreachable checks in policies in [google/cel-java#423 #### Fixes - Do not override the container if it's missing from policy config in [google/cel-java#401 - Add option to specify folding designated custom functions only in [google/cel-java#402 - Fix conditionally nested rules to include its condition in [google/cel-java#404 - Fix runtime equality behavior for sets extension in [google/cel-java#416 - Reduce count of errors joined together during parsing error in [google/cel-java#417 [google/cel-java#418 #### Miscellaneous Changes - Upgrade protobuf version to 4.28.0 in [google/cel-java#439 - Remove unused list/map conversion functions from standard definitions in [google/cel-java#406 - Open source Java conformance tests in [google/cel-java#413 - Change cel_spec repo url to 0.16.0 in WORKSPACE in [google/cel-java#419 - Migrate test_all_types proto over to the cel-spec variant in [google/cel-java#433 **Full Changelog**: google/cel-java@v0.6.0...v0.7.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/googleapis/sdk-platform-java). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC41OS4yIiwidXBkYXRlZEluVmVyIjoiMzguNTkuMiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enforce composed AST stays below the configured depth limit