Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'test all' definitions #296

Merged
merged 2 commits into from
Jul 6, 2023
Merged

Conversation

Alfus
Copy link
Contributor

@Alfus Alfus commented Jun 26, 2023

To complete the set of local .proto definitions for the conformance tests. Note that the uri's of the Any's in the conformance test data will need to be updated to migrate to these definitions.

@Alfus
Copy link
Contributor Author

Alfus commented Jun 30, 2023

Results in the packages:
image

@TristonianJones
Copy link
Collaborator

/gcbrun

@TristonianJones TristonianJones self-assigned this Jul 5, 2023
@TristonianJones TristonianJones self-requested a review July 5, 2023 18:12
@TristonianJones TristonianJones removed their assignment Jul 5, 2023
@TristonianJones
Copy link
Collaborator

/gcbrun

@TristonianJones
Copy link
Collaborator

/gcbrun

@TristonianJones
Copy link
Collaborator

@Alfus running the bazel build locally seems to be fine. I'm not sure why Cloud Build is unhappy, but I'll merge soon and sort out the GCB issues separately given the local builds / tests seem fine.

@TristonianJones TristonianJones merged commit 0c84135 into google:master Jul 6, 2023
1 of 2 checks passed
@Alfus Alfus deleted the afuller/testall branch July 14, 2023 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants