Search whole chain looking for issuer match #1112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhutchinson
requested review from
AlCutter and
pphaneuf
and removed request for
a team
2 tasks
AlCutter
approved these changes
Jul 10, 2023
AlCutter
approved these changes
Jul 10, 2023
|
This PR unfortunately doesn't work, as I describe here: 17fed18#r121525697 |
mhutchinson
added a commit
to mhutchinson/certificate-transparency-go
that referenced
this pull request
Jul 14, 2023
…e#1112 The previous check always failed. This check ensures that the issuer is correct by confirming the signature of the cert.
mhutchinson
added a commit
that referenced
this pull request
Jul 14, 2023
…#1114) The previous check always failed. This check ensures that the issuer is correct by confirming the signature of the cert.
|
I've taken your fix and applied it in #1114. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a more thorough alternative to #1111 to solve #1096 as I understand the problem.
Where the chain is out of order, look through the whole chain to find a matching issuer cert. If we don't find one, then use the fallback logic that was already there for no issuer chain provided.