Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TLS support for CTLog server #1523

Merged
merged 1 commit into from
Jul 4, 2024
Merged

Conversation

fghanmi
Copy link
Contributor

@fghanmi fghanmi commented Jul 1, 2024

Summary

This pull request introduces support for enabling TLS security for CTLog. By adding two new command-line flags--tls_certificate and --tls_key which represents the path to server TLS certificate and private key respectively.
And also implementing the necessary logic to handle TLS, this update enhances the security of CTLog.

Release Note

  • Feature: Added support for TLS security for CTLog server.
    New Flags: --tls_certificate and --tls_key to specify the file path for service certificate and private key.
    Behavior: If --tls_certificate and --tls_key flags are not both provided, the system will default to insecure connections.
    Security: This update significantly enhances the security of data in transit by enabling TLS.

Resolves Issue: #1522

Checklist

@fghanmi fghanmi requested a review from a team as a code owner July 1, 2024 08:48
@fghanmi fghanmi requested review from mhutchinson and removed request for a team July 1, 2024 08:48
Copy link

google-cla bot commented Jul 1, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@fghanmi
Copy link
Contributor Author

fghanmi commented Jul 1, 2024

Hello,
It seems that "Missing permissions: cloudbuild.builds.get" prevents the build from starting/succeeding.
Could you please help ?
Thanks!

@fghanmi fghanmi force-pushed the TLSSupport branch 4 times, most recently from 3edaf50 to 0b4f592 Compare July 4, 2024 07:01
@mhutchinson
Copy link
Contributor

/gcbrun

Signed-off-by: Firas Ghanmi <fghanmi@redhat.com>
@mhutchinson
Copy link
Contributor

/gcbrun

@mhutchinson
Copy link
Contributor

Hey @fghanmi one tip to make incremental github reviews easier for the reviewer: once a commit has been proposed, make any further changes as commits on top of that instead of squashing the commits together and force pushing. This makes it easier to see that recent changes have not affected code that a reviewer may already have looked at. The commits can all be squashed together at the point where the PR is merged into the main branch.

@mhutchinson mhutchinson merged commit 20f4453 into google:master Jul 4, 2024
6 checks passed
fghanmi added a commit to securesign/certificate-transparency-go that referenced this pull request Jul 15, 2024
Signed-off-by: Firas Ghanmi <fghanmi@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants