Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

fixes error thrown when using charts in page- or tabview #452

Closed
wants to merge 1 commit into from

Conversation

jplekkerkerker
Copy link

As mentioned in #277 the BaseChartState throws an error when skipping over in a page- or tabview. I've implemented the check as mentioned in the pull request and that fixes the problem.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@jplekkerkerker
Copy link
Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels May 1, 2020
Copy link

@92Andy 92Andy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good!

@92Andy
Copy link

92Andy commented Jun 9, 2020

Apparently someone is needed who has the necessary write access. Can someone approve this fix please?

@winksaville
Copy link

There is a fork of charts at exafree/charts_cf that accepts pull requests.

Copy link

@yemlihaoner yemlihaoner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this solved our memory leak bug on dispose()

@stuartmorgan
Copy link
Collaborator

This project is no longer maintained, and cannot accept any PRs. Community members interested in collaborating on a community-maintained fork can coordinate in this issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants