fix: remove online check #936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Grant Timmerman <granttimmerman@gmail.com>
Signed-off-by: Grant Timmerman <granttimmerman@gmail.com>
sqrrrl
approved these changes
Sep 1, 2022
|
This error prevented us from using clasp. Thanks @grant! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes online check. I believe this was added from a user's PR from long ago, but it has caused many user errors over the years. The CLI shouldn't even special case to check if the client is online, the client should just directly try. The implementation is kind of scary when you look at it (not attempted to change / remove).
Fixes #872
Fixes #934
Fixes #886
Fixes #913
Fixes #909
Fixes #930
npm run testsucceeds.npm run lintsucceeds.R=@sqrrrl