Enable --instrument_async_context by default in JSCompiler for all …

…JS builds, with the exception of whitespace-only builds. PiperOrigin-RevId: 662248606
google · Aug 14, 2024 · c906392 · c906392
1 parent 859f56e
commit c906392
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 8 deletions.
diff --git a/src/com/google/javascript/jscomp/deps/ModuleNames.java b/src/com/google/javascript/jscomp/deps/ModuleNames.java
@@ -62,7 +62,6 @@ static String toJSIdentifier(String path) {
         .replace('\\', '$')
         .replace('@', '$')
         .replace('+', '$')
-        .replace('!', '$')
         .replace('-', '_')
         .replace(':', '_')
         .replace('.', '_')

diff --git a/test/com/google/javascript/jscomp/deps/ModuleLoaderTest.java b/test/com/google/javascript/jscomp/deps/ModuleLoaderTest.java
@@ -260,13 +260,6 @@ public void testCanonicalizePath() {
     assertThat(ModuleNames.canonicalizePath("/a/..")).isEqualTo("/");
   }
 
-  @Test
-  public void testToJSIdentifier() {
-    assertThat(ModuleNames.toJSIdentifier("com/example/test")).isEqualTo("com$example$test");
-    assertThat(ModuleNames.toJSIdentifier("file://a/b.jar!com/example/test"))
-        .isEqualTo("file_$$a$b_jar$com$example$test");
-  }
-
   @Test
   public void testEscapePath() {
     ModuleLoader loader =