RELNOTES: Fix edge-case in TestCase autodiscovery.

PiperOrigin-RevId: 329396478
google · Sep 3, 2020 · d4df5d4 · d4df5d4
1 parent fb4ad0e
commit d4df5d4
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/closure/goog/testing/testcase.js b/closure/goog/testing/testcase.js
@@ -1435,7 +1435,7 @@ goog.testing.TestCase.prototype.addTestObj_ = function(obj, name, objChain) {
       var fullTestName = name + (testName && name ? '_' : '') + testName;
       if (goog.isFunction(testProperty)) {
         this.addNewTest(fullTestName, testProperty, obj, objChain);
-      } else if (goog.isObject(testProperty)) {
+      } else if (goog.isObject(testProperty) && !Array.isArray(testProperty)) {
         // To prevent infinite loops.
         if (!goog.array.contains(objChain, testProperty)) {
           goog.asserts.assertObject(testProperty);

diff --git a/closure/goog/testing/testcase_test.js b/closure/goog/testing/testcase_test.js
@@ -179,6 +179,20 @@ goog.global.mockTestName = function() {
   return failGoogPromise();
 };
 
+/**
+ * A variable with the same autodiscovery prefix, used by
+ * `testInitializeTestCase`. TestCase does not support auto-discovering tests
+ * within Arrays, either as functions added to the array object or as a value
+ * within the array (as it never recurses into the content of the array).
+ */
+goog.global.mockTestNameValues = ['hello', 'world'];
+/**
+ * @return {!GoogPromise<?>}
+ */
+goog.global.mockTestNameValues.mockTestNameTestShouldNotBeRun = function() {
+  return failGoogPromise();
+};
+
 testSuite({
   setUp() {
     events = [];