Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add honggfuzz to project setup. #1196

Merged
merged 3 commits into from
Nov 15, 2019
Merged

Add honggfuzz to project setup. #1196

merged 3 commits into from
Nov 15, 2019

Conversation

oliverchang
Copy link
Collaborator

@oliverchang oliverchang commented Nov 15, 2019 •
edited
Loading

@googlebot googlebot added the cla: yes CLA signed. label Nov 15, 2019
@oliverchang
Copy link
Collaborator Author

/gcbrun

@oliverchang
Copy link
Collaborator Author

/gcbrun

@oliverchang oliverchang merged commit 50729da into master Nov 15, 2019
inferno-chromium
inferno-chromium reviewed Nov 15, 2019
View reviewed changes
Copy link
Collaborator

@inferno-chromium inferno-chromium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I think we need to update environment.is_engine_fuzzer_job and any other similar places that check against libfuzzer, afl. like search for is_afl_job, is_libfuzzer_job

src/appengine/handlers/cron/project_setup.py
'honggfuzz_asan_',
'honggfuzz',
'address', ['honggfuzz', 'engine_asan'],
minimize_job_override=LIBFUZZER_ASAN_JOB)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eventually we want to support native minimization using fuzzing engine itself, does honggfuzz support that ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so.. (https://github.com/google/honggfuzz/blob/master/docs/USAGE.md)

@oliverchang
Copy link
Collaborator Author

LGTM.

I think we need to update environment.is_engine_fuzzer_job and any other similar places that check against libfuzzer, afl. like search for is_afl_job, is_libfuzzer_job

Done in #1197.

@oliverchang oliverchang deleted the honggfuzz-setup branch November 19, 2019 02:17
Dor1s
Dor1s reviewed Nov 22, 2019
View reviewed changes
Copy link
Contributor

@Dor1s Dor1s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inferno-chromium inferno-chromium inferno-chromium left review comments

@Dor1s Dor1s Dor1s left review comments

Assignees
No one assigned
Labels
cla: yes CLA signed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@oliverchang @Dor1s @inferno-chromium @googlebot