Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rearchitecture] Refactor analyze_task. #3032

Merged
merged 3 commits into from
May 8, 2023
Merged

Conversation

jonathanmetzman
Copy link
Collaborator

@jonathanmetzman jonathanmetzman commented May 8, 2023

Refactor analyze_task so it is easier to split up when we move tasks to the new untrusted model.
This is a nonfunctional change.

Refactor analyze_task so it is easier to split up when we move
tasks to the new untrusted model.
@jonathanmetzman
Copy link
Collaborator Author

Related: #3008

@jonathanmetzman jonathanmetzman marked this pull request as ready for review May 8, 2023 01:57
Copy link
Contributor

@DonggeLiu DonggeLiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nits



def execute_task(testcase_id, job_type):
"""Run analyze task."""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: 'Runs'

@jonathanmetzman jonathanmetzman merged commit bcbcb6d into master May 8, 2023
@jonathanmetzman jonathanmetzman deleted the refactor-analyze branch May 8, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants