Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix autohealing policy update logic. #4264

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Conversation

letitz
Copy link
Collaborator

@letitz letitz commented Sep 20, 2024

There are two logic fixes:

  1. API field names are in camelCase, not snake_case.
  2. Previously, we would treat trying to update a single field as an error and delete the policy.
    It is only an error to supply a single field in the config, but we may legitimately find a single field needs updating.

Also moved config validation to loading time. It would likely be best to explode if the auto-healing policy in the config has a single field set, instead of ignoring it with a warning, but this preserves behavior for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant