Skip to content

Commit

Permalink
Name our release profile sonatype-oss-release instead of release.
Browse files Browse the repository at this point in the history
This matches what we do for most of our other projects.

(Compile-Testing seems to be the only project that uses a particular feature, `<releaseProfiles>`, so I'm kind of just guessing that I need to update the value there to match.)

Motivation: I had trouble releasing 0.20 in part because I was trying to use `-P sonatype-oss-release`. I eventually succeeded by setting _both_ that _and_ `-P release`, but it would be nice not to need that next time. The specific problem appeared to be at least partially about getting an ancient "default" version of `maven-gpg-plugin` instead of the version specified inside the release profile. (And then I had an additional issue from possibly losing my `.m2/settings.xml` when I got a new machine....) Hopefully this new fix is correct, though I guess I'll have to carefully start but not finish a release to be sure.
RELNOTES=n/a
PiperOrigin-RevId: 492199969
  • Loading branch information
cpovirk authored and Compile-Testing Team committed Dec 1, 2022
1 parent ea22b1d commit 75b95ed
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@
<artifactId>maven-release-plugin</artifactId>
<version>2.5.3</version>
<configuration>
<releaseProfiles>release</releaseProfiles>
<releaseProfiles>sonatype-oss-release</releaseProfiles>
<goals>deploy</goals>
</configuration>
</plugin>
Expand Down Expand Up @@ -174,7 +174,7 @@
</dependencies>
</profile>
<profile>
<id>release</id>
<id>sonatype-oss-release</id>
<activation>
<activeByDefault>false</activeByDefault>
</activation>
Expand Down

0 comments on commit 75b95ed

Please sign in to comment.