Remove unused callback from GUI exercise #1293
Conversation
For readability.
Exercise 31.1 needs use tempfile::tempfile; to work, and also for `tempfile = "3"` to be added to Cargo.toml.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
... as per discussion.
|
That's done. At least, I've updates the code in the branch and re-pushed. TBH, I don't use pull requests all that much, so I'm not certain whether I have to do anything else, but I can see the update on the main repo, so I presume you can too? |
The push is good, I also see the new changes here. The only missing thing is the CLA bot (both here and in your other pull request). When the CLA is signed, then we can merge the PRs. |
|
I've signed a CLA. |
Great, I told the bot to run the check again and it all looks good now. Thanks a lot for the help! |
|
Sorry, typo. I mean caller, not called! |
Ah, I did a best-effort on-the-fly update 😄 Feel free to submit a patch for this (I recommend using the little pencil icon in the top-right of the Drawing A Simple GUI page). |
Here's a possible update to the GUI/TUI exercise, taking out the callback and explaining (slightly).
See what you think.