-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Format all PO files with dprint
#1359
Conversation
Note that this will require translators to install the Gettext tools and |
We'll probably need to update the instructions in TRANSLATE.md, right? |
Yes! Thanks, that's a great point! |
@henrif75 what do you think of the update to TRANSLATIONS? |
They're great, thanks! |
This enforces a consistent formatting for the PO files. The goal of this is to avoid large diffs due to random and unnecessary reformatting. We use the format of `msgcat`: this is also waht `msgmerge` produces and it’s easy to replicate for people by installing Gettext and running `dprint fmt`. The existing files were updated to match: 15 out of 18 translations already followed the new format! I incremented the POT-Creation-Date fields by one day: the precise date does not matter much since the translations in question are incomplete and not yet published. This is a follow-up to #1351 which started enforcing that the `msgid` fields don’t change due to reformatting in a PR. If this turns out to be cumbersome, then we can disable it again.
This enforces a consistent formatting for the PO files. The goal of this is to avoid large diffs due to random and unnecessary reformatting.
We use the format of
msgcat
: this is also wahtmsgmerge
produces and it’s easy to replicate for people by installing Gettext and runningdprint fmt
.This is a follow-up to #1351 which started enforcing that the
msgid
fields don’t change due to reformatting in a PR.If this turns out to be cumbersome, then we can disable it again.