Fixture code and footer content tags in rtl content #1433

moaminsharifi · 2023-10-27T07:01:22Z

Issue:

In the code part of content which always is in english and must be text-align: left but with <html ... dir=rtl > cuz conflict.

For example:

other one in footer:

how must be:

Suggestion:

Due to the fact that the other way @mgeisler at issue 1413 suggested doesn't work at all, we need to modify the CSS

Adding rtl.css file with those content:

[dir="rtl"] .hljs,
[dir="rtl"] pre > code {
  text-align: left;
}
[dir="rtl"] #cookieBar {
  direction: ltr;
}

Small Update existent Part 1,2

Update some of words double check `#, fuzzy` part and sync their translations

… '\n'`

Co-authored-by: Kaveh <hamidrkp@riseup.net>

Fix half-space

hamidrezakp · 2023-10-27T08:43:06Z

@moaminsharifi Thank you.
But your branch contains unrelated commits too. can you do a rebase on google/comprehensive-rust/main and force-push again?

hamidrezakp · 2023-10-27T08:51:47Z

Also, have you tried adding dir="auto" to element?
Browser itself will choose the right direction for text. if it starts with a RTL language it will be RTL and if LTR, it will be LTR.
That's way better and it makes text BIDI.
But we have to have it on every text element on the page, and it must be generated from mdbook.

moaminsharifi · 2023-10-27T09:33:48Z

@moaminsharifi Thank you. But your branch contains unrelated commits too. can you do a rebase on google/comprehensive-rust/main and force-push again?

I will do it later,

Also, have you tried adding dir="auto" to element? Browser itself will choose the right direction for text. if it starts with a RTL language it will be RTL and if LTR, it will be LTR. That's way better and it makes text BIDI. But we have to have it on every text element on the page, and it must be generated from mdbook.

Those specific parts like <pre> and <code> tags as I checked only we use for Rust code, Bash and any other english texts.

Plus adding <tag ... dir=auto> with js may cuz issue when:
1- user not enabled js
2- conflict with js render of code blocks
#1413 (comment)

hamidrezakp · 2023-10-27T09:38:43Z

Plus adding <tag ... dir=auto> with js may cuz issue when: 1- user not enabled js 2- conflict with js render of code blocks #1413 (comment)

Not with js, but with be generated with mdbook.

mgeisler · 2023-10-27T10:15:34Z

Thanks for looking at this!

In the code part of content which always is in english and must be text-align: left but with <html ... dir=rtl > cuz conflict.

This is not technically true: the Simplified Chinese translation actually translated some of the Rust comments:

I don't know how this would be expected to look in Persian, but I just wanted to mention that it is possible to translate this (that's actually why the code snippets are in the PO files). Please also see google/mdbook-i18n-helpers#95 and let us know there if this is a terrible idea from the point of view of right-to-left text. I suspect that it is?

moaminsharifi · 2023-10-27T12:19:28Z

Thanks for looking at this!

In the code part of content which always is in english and must be text-align: left but with <html ... dir=rtl > cuz conflict.

This is not technically true: the Simplified Chinese translation actually translated some of the Rust comments:

I don't know how this would be expected to look in Persian, but I just wanted to mention that it is possible to translate this (that's actually why the code snippets are in the PO files). Please also see google/mdbook-i18n-helpers#95 and let us know there if this is a terrible idea from the point of view of right-to-left text. I suspect that it is?

as I mentioned in the #1413 (comment)
The issue is mostly about
normal part like:
```
fn main() {
println!("Edit me!");
}
```
or
```rust| bash
fn main() {
println!("Edit me!");
}
```

which use web-kit value

when we add editable to code block then will be fixed.

About rendering this part:

```rust,editable
fn main() { // Program entry point
let mut x: i32 = 6; // Mutable variable binding
print!("{x}"); // Macro for printing, like printf
while x != 1 { // No parenthesis around expression
if x % 2 == 0 { // Math like in other languages
x = x / 2;
} else {
x = 3 * x + 1;
}
print!(" -> {x}");
}
println!();
}
```

It's seems totally ok for me. (again, because we use rust,editable then it is always text algin left)

About google/mdbook-i18n-helpers#95, how we must convert this part in to .po file?
```rust,editable
fn main() { // Program entry point
let mut x: i32 = 6; // Mutable variable binding
print!("{x}"); // Macro for printing, like printf
while x != 1 { // No parenthesis around expression
if x % 2 == 0 { // Math like in other languages
x = x / 2;
} else {
x = 3 * x + 1;
}
print!(" -> {x}");
}
println!();
}
```
Now We just take whole part as msgid. if we separate it like as we know // is a way to comment in the line after the code in Rust.
How We must handle msgid and msgstr? can You @mgeisler give me an example?

@hamidrezakp for using mbBook I am not sure how we can change rendering.

mgeisler · 2023-10-27T12:46:18Z

How We must handle msgid and msgstr? can You @mgeisler give me an example?

If you're asking what the msgid and msgstr fields do in the PO file, then please read TRANSLATIONS.md and let me know if you still have questions. In short, msgid is populated with the English text and msgstr is the corresponding translation.

Manishearth · 2023-10-30T17:14:59Z

You would not want to render code in RTL even if it has comments in an RTL script; because Rust code is still primarily LTR (and the braces/etc will get strange in RTL). The comments should get the bidi algorithm run on them just fine and render correctly anyway. If you are using RTL identifiers and such that can be trickier, would recommend people using those to use the appropriate bidi formatting codepoints (full algorithm described here, eventually I'd like rustfmt to be able to do this automatically)

I think this PR is correct.

mgeisler

Thanks for the code, @moaminsharifi and thanks for the review, @Manishearth!

mgeisler · 2023-10-31T06:36:24Z

Now We just take whole part as msgid. if we separate it like as we know // is a way to comment in the line after the code in Rust. How We must handle msgid and msgstr? can You @mgeisler give me an example?

Luckily @dalance gave an example in the PR: google/mdbook-i18n-helpers#109 (comment).

I expect to merge the PR soon and then we'll create a new release of mdbook-i18n-helpers. Then we'll see how it impacts RTL text (or you can already try it out with the code in the PR).

Part of: #671 #1433 ## Issue: When we render SVG tags in persian ( `<html dir="rtl" ...>`) make confiliect: ![svg-rtl-issue](https://github.com/google/comprehensive-rust/assets/11869014/ce825736-4367-41fa-acd3-6e395926d7c7) originally: *[7.2 Arrays and for Loops](https://google.github.io/comprehensive-rust/exercises/day-1/for-loops.html#arrays-and-for-loops)* ![svg-rtl-issue-2](https://github.com/google/comprehensive-rust/assets/11869014/0a494392-2407-47ec-91f1-0098414b83d3) originally: *[16.2 Moved Strings in Rust](https://google.github.io/comprehensive-rust/ownership/moved-strings-rust.html)* ## Proposed method: as we talked in #1433, again in there adding ``` [dir="rtl"] svg { direction: ltr; } ``` fix issue like: ![svg-rtl-issue-fix](https://github.com/google/comprehensive-rust/assets/11869014/5d82c413-709a-42dd-b24b-1ff2c8be55ba) ![svg-rtl-issue-2-fixture](https://github.com/google/comprehensive-rust/assets/11869014/da2bf319-212e-4edd-9135-82f51e5e0381)

moaminsharifi and others added 16 commits October 25, 2023 14:06

Refreshing an Existing Translation

9dfb689

Update Translation of src/SUMMARY.md

1645093

Update Translation dude to google#1427 (review)

0f5f4aa

Fix half space in summary part

5286780

Delete no longer needed from paper bin. ref google#1427 (comment)

65e0809

Merge branch 'google:main' into main

fae0ecb

Add new Translation of Part 1,2

00f2e81

Small Update existent Part 1,2

Fix miss spells

ccb0855

Update some of words double check `#, fuzzy` part and sync their translations

Format file with dprint fmt po/fa.po

a0ee1ef

Fix `po/fa.po:1701: 'msgid' and 'msgstr' entries do not both end with…

ad45d6b

… '\n'`

Update po/fa.po

7f24f1e

Co-authored-by: Kaveh <hamidrkp@riseup.net>

revert changes of "POT-Creation-Date: 2023-08-23\n" line

5adafcf

Add suggestions

780991d

Fix half-space

reformated

8ec9572

Merge branch 'google:main' into main

90dab91

fixture code tags in rtl content

3b3fb8f

moaminsharifi requested review from mgeisler and hamidrezakp October 27, 2023 07:01

mgeisler approved these changes Oct 31, 2023

View reviewed changes

mgeisler merged commit 8f42baf into google:main Oct 31, 2023
30 checks passed

moaminsharifi mentioned this pull request Oct 31, 2023

fa: Translate Part 3 , 4 , 5 ,6.1, 6.2, 6.3 #1439

Merged

moaminsharifi mentioned this pull request Nov 8, 2023

Fix SVG renders in RTL contents #1454

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixture code and footer content tags in rtl content #1433

Fixture code and footer content tags in rtl content #1433

moaminsharifi commented Oct 27, 2023

hamidrezakp commented Oct 27, 2023

hamidrezakp commented Oct 27, 2023

moaminsharifi commented Oct 27, 2023 •

edited

Loading

hamidrezakp commented Oct 27, 2023

mgeisler commented Oct 27, 2023

moaminsharifi commented Oct 27, 2023

mgeisler commented Oct 27, 2023

Manishearth commented Oct 30, 2023

mgeisler left a comment

mgeisler commented Oct 31, 2023

Fixture code and footer content tags in rtl content #1433

Fixture code and footer content tags in rtl content #1433

Conversation

moaminsharifi commented Oct 27, 2023

Issue:

For example:

how must be:

Suggestion:

hamidrezakp commented Oct 27, 2023

hamidrezakp commented Oct 27, 2023

moaminsharifi commented Oct 27, 2023 • edited Loading

hamidrezakp commented Oct 27, 2023

mgeisler commented Oct 27, 2023

moaminsharifi commented Oct 27, 2023

mgeisler commented Oct 27, 2023

Manishearth commented Oct 30, 2023

mgeisler left a comment

Choose a reason for hiding this comment

mgeisler commented Oct 31, 2023

moaminsharifi commented Oct 27, 2023 •

edited

Loading