Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update translation file with v2 of book #1470

Conversation

moaminsharifi
Copy link
Collaborator

Message Ids synced with updated messages.po
Part of #671

Copy link
Collaborator

@DannyRavi DannyRavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

before commit and push please use dprint fmt po/fa.po for code Formatting.

@moaminsharifi
Copy link
Collaborator Author

moaminsharifi commented Nov 20, 2023

before commit and push please use dprint fmt po/fa.po for code Formatting.

Thanks @DannyRavi for mention it.
Because of normalize issue I maked it draft. for now I am waiting for review of #1453 after it I will reopen it.

@mgeisler
Copy link
Collaborator

Hi @moaminsharifi and @DannyRavi, have you been able to fix the normalization issues?

If the merge/rebase gives you trouble, I would suggest just redoing the PR (since I assume it doesn't contain changes apart from extracting the new strings and then running msgmerge?).

@mgeisler
Copy link
Collaborator

Oh, I think I just duplicated this in #1751... please review either one so we can get things updated.

@mgeisler
Copy link
Collaborator

Let us close this one, it got superseded by #1751.

@mgeisler mgeisler closed this Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants