Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Markdown in build-rules.md #1530

Merged
merged 1 commit into from
Nov 30, 2023
Merged

Fix Markdown in build-rules.md #1530

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/chromium/build-rules.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ You can also add `deps` on other Rust targets. Later we'll use this to
depend upon third party code.

<details>

You must specify _both_ the crate root, _and_ a full list of sources.
The `crate_root` is the file given to the Rust compiler representing the root
file of the compilation unit --- typically `lib.rs`. `sources` is a complete
Expand All @@ -33,6 +34,7 @@ Students might be wondering why we need a gn template, rather than using
[gn's built-in support for Rust static libraries][0].
The answer is that this template provides support for cxx interop, Rust features,
and unit tests, some of which we'll use later.

</details>

[0]: https://gn.googlesource.com/gn/+/main/docs/reference.md#func_static_library
Loading