-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ko: refresh translation for bare-metal #928
Conversation
Hi @jooyunghan, please skim through the translation and let me know if there is anything to fix (via the GitHub suggestions so that I can apply the fixes directly). Thanks! |
He's on a vacation now. Let me finish this by EoW. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. This was very tough...
I still am not 100% satisfied with the translation, but this should at least be readable. |
Thank you very much for all the fixes! I'll commit them now and solve the merge conflict. It should be easier to fix small things afterwards. |
Part of #925. Co-authored-by: Jiyong Park <55639800+jiyongp@users.noreply.github.com>
Everything is applied and I fixed the merge conflict by moving the new translations to their approximate correct spot. Things will move around again when we run |
Thanks, @mgeisler for the final step. I can see the translated page very well. https://google.github.io/comprehensive-rust/ko/bare-metal.html |
@jiyongp, thanks for your tremendous help here! |
Part of google#925. Co-authored-by: Jiyong Park <55639800+jiyongp@users.noreply.github.com>
Part of #925.