Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ko: refresh translation for bare-metal #928

Merged
merged 1 commit into from
Aug 9, 2023
Merged

ko: refresh translation for bare-metal #928

merged 1 commit into from
Aug 9, 2023

Conversation

mgeisler
Copy link
Collaborator

Part of #925.

@mgeisler
Copy link
Collaborator Author

Hi @jooyunghan, please skim through the translation and let me know if there is anything to fix (via the GitHub suggestions so that I can apply the fixes directly). Thanks!

@jiyongp
Copy link
Collaborator

jiyongp commented Aug 8, 2023

Hi @jooyunghan, please skim through the translation and let me know if there is anything to fix (via the GitHub suggestions so that I can apply the fixes directly). Thanks!

He's on a vacation now. Let me finish this by EoW.

po/ko.po Outdated Show resolved Hide resolved
po/ko.po Outdated Show resolved Hide resolved
po/ko.po Outdated Show resolved Hide resolved
po/ko.po Outdated Show resolved Hide resolved
po/ko.po Outdated Show resolved Hide resolved
po/ko.po Outdated Show resolved Hide resolved
po/ko.po Outdated Show resolved Hide resolved
po/ko.po Outdated Show resolved Hide resolved
po/ko.po Outdated Show resolved Hide resolved
po/ko.po Outdated Show resolved Hide resolved
po/ko.po Outdated Show resolved Hide resolved
po/ko.po Outdated Show resolved Hide resolved
po/ko.po Outdated Show resolved Hide resolved
po/ko.po Outdated Show resolved Hide resolved
po/ko.po Outdated Show resolved Hide resolved
po/ko.po Outdated Show resolved Hide resolved
po/ko.po Outdated Show resolved Hide resolved
po/ko.po Outdated Show resolved Hide resolved
po/ko.po Outdated Show resolved Hide resolved
po/ko.po Outdated Show resolved Hide resolved
po/ko.po Outdated Show resolved Hide resolved
po/ko.po Outdated Show resolved Hide resolved
po/ko.po Outdated Show resolved Hide resolved
po/ko.po Outdated Show resolved Hide resolved
po/ko.po Outdated Show resolved Hide resolved
po/ko.po Outdated Show resolved Hide resolved
po/ko.po Outdated Show resolved Hide resolved
po/ko.po Outdated Show resolved Hide resolved
po/ko.po Outdated Show resolved Hide resolved
po/ko.po Outdated Show resolved Hide resolved
po/ko.po Outdated Show resolved Hide resolved
po/ko.po Outdated Show resolved Hide resolved
po/ko.po Outdated Show resolved Hide resolved
po/ko.po Outdated Show resolved Hide resolved
po/ko.po Outdated Show resolved Hide resolved
po/ko.po Outdated Show resolved Hide resolved
po/ko.po Outdated Show resolved Hide resolved
po/ko.po Outdated Show resolved Hide resolved
po/ko.po Outdated Show resolved Hide resolved
po/ko.po Outdated Show resolved Hide resolved
po/ko.po Outdated Show resolved Hide resolved
Copy link
Collaborator

@jiyongp jiyongp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. This was very tough...

@jiyongp
Copy link
Collaborator

jiyongp commented Aug 9, 2023

I still am not 100% satisfied with the translation, but this should at least be readable.

@mgeisler
Copy link
Collaborator Author

mgeisler commented Aug 9, 2023

I still am not 100% satisfied with the translation, but this should at least be readable.

Thank you very much for all the fixes! I'll commit them now and solve the merge conflict. It should be easier to fix small things afterwards.

Part of #925.

Co-authored-by: Jiyong Park <55639800+jiyongp@users.noreply.github.com>
@mgeisler
Copy link
Collaborator Author

mgeisler commented Aug 9, 2023

Everything is applied and I fixed the merge conflict by moving the new translations to their approximate correct spot. Things will move around again when we run msgmerge — that's okay, I only care about the number of untranslated messages overall.

@mgeisler mgeisler enabled auto-merge (squash) August 9, 2023 08:16
@mgeisler mgeisler merged commit 981360c into main Aug 9, 2023
32 checks passed
@mgeisler mgeisler deleted the ko-bare-metal branch August 9, 2023 08:28
@jiyongp
Copy link
Collaborator

jiyongp commented Aug 9, 2023

Thanks, @mgeisler for the final step. I can see the translated page very well. https://google.github.io/comprehensive-rust/ko/bare-metal.html

@mgeisler
Copy link
Collaborator Author

mgeisler commented Aug 9, 2023

@jiyongp, thanks for your tremendous help here!

yohcop pushed a commit to yohcop/comprehensive-rust that referenced this pull request Sep 12, 2023
Part of google#925.

Co-authored-by: Jiyong Park <55639800+jiyongp@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants