Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Arc and Mutex to Arc/Mutex example #95

Closed
wants to merge 1 commit into from

Conversation

sudonym1
Copy link
Contributor

@sudonym1 sudonym1 commented Jan 2, 2023

No description provided.

@mgeisler
Copy link
Collaborator

mgeisler commented Jan 3, 2023

Hey @sudonym1,

Thanks for the PR — I think you basically "solved" it by adding the code which I normally add when live-coding in class 😄 That is, your changes are better suited for a speaker note (#53) than the main text.

@mgeisler
Copy link
Collaborator

mgeisler commented Jan 5, 2023

@sudonym1 could you please recast this as an update to the speaker notes? Start by adding a <details> ... </details> block to the page and then explain things inside it. Tell the instructor what they should remember to show to the students.

Copy link
Collaborator

@mgeisler mgeisler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the speaker notes instead.

@sudonym1
Copy link
Contributor Author

sudonym1 commented Jan 5, 2023

Sure, I can do that.

@mgeisler
Copy link
Collaborator

mgeisler commented Jan 6, 2023

Sure, I can do that.

Awesome 😄 You simply need a <details> ... </details> element with some Markdown at the bottom of the page, that's it. There are a few examples of this in the course now: https://google.github.io/comprehensive-rust/welcome-day-1.html

@mgeisler
Copy link
Collaborator

Let me close this PR for now — please open another with updated speaker notes if you find time 😄

@mgeisler mgeisler closed this Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants