Save manifest json and digest, and allow specifying platform when pulling images #113
Conversation
ixdy
force-pushed
the
platforms-and-digests
branch
from
762e4eb to
5e55649
Compare
| 001.tar.gz <-- the first layer's .tar.gz filesystem delta | ||
| 001.sha256 <-- the sha256 of 1.tar.gz with a "sha256:" prefix. | ||
| config.json <-- only *.json, the image's config | ||
| digest <-- sha256 digest of the image's manifest |
There was a problem hiding this comment.
I'm wondering will changing the file structure impact the docker's compatibility to read those image tars?
There was a problem hiding this comment.
This change shouldn't affect the code path which produces a tarball that you can docker load - that's produced by the tarball and multi_image_tarball functions, which don't use fast or uncompressed.
I think the only consumer of this directory is v2_2_image.FromDisk, and it looks like it doesn't particularly care about the directory structure, either.
I wish the tests were actually usable, though; it would make me more confident about this change.
|
I discovered that I can run the tests locally if I use |
|
attempting to get this reviewed internally instead. |
These are a few enhancements needed by bazelbuild/rules_docker#543.
First, I'm saving the
manifest.jsonand docker digest of this manifest out to files. This lets us figure out the resolved digest from a tag, so we can reproduce the pull later.Second, I've added a flag to control which platform image to pull from a manifest list. This way we can let builds be explicit, rather than always pulling
linux/amd64(or worse, whatever is their host platform).I've tested this manually by pulling several images, but I can't seem to get the tests to run under
bazel test- it wants to write out to my$HOME/.config/gcloud/credentials.db, which seems broken.